-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove beta categoryAndTagApprovers #56723
Conversation
@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Sorry @s77rt , assigned @allgandalf as he won the slack dice roll |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2025-02-12.at.11.47.18.PM.movScreen.Recording.2025-02-12.at.11.45.04.PM.movScreen.Recording.2025-02-12.at.11.49.12.PM.movMacOS: DesktopScreen.Recording.2025-02-12.at.11.51.21.PM.moviOS: NativeScreen.Recording.2025-02-12.at.11.53.10.PM.moviOS: mWeb SafariScreen.Recording.2025-02-12.at.11.54.50.PM.movAndroid: NativeScreen.Recording.2025-02-12.at.11.57.38.PM.movAndroid: mWeb ChromeScreen.Recording.2025-02-12.at.11.59.42.PM.mov |
const policy = usePolicy(policyID); | ||
const hasAccountingConnections = PolicyUtils.hasAccountingConnections(policy); | ||
const {canUseCategoryAndTagApprovers} = usePermissions(); | ||
const policyHasAccountingConnections = hasAccountingConnections(policy); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To trouble you a little, we have the following guideline:
import { specificMethod as specificMethodSpecificModule } from '@libs/SpecificModule';
if variable name and module name are the same, this is honestly NAB for me, but just saying as there was this slack post :
![Screenshot 2025-02-12 at 11 35 36 PM](https://private-user-images.githubusercontent.com/110545952/412554458-8f39ba94-7515-4012-8035-cfa8e943e8fc.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1OTg1MDksIm5iZiI6MTczOTU5ODIwOSwicGF0aCI6Ii8xMTA1NDU5NTIvNDEyNTU0NDU4LThmMzliYTk0LTc1MTUtNDAxMi04MDM1LWNmYThlOTQzZThmYy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQwNTQzMjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01N2ZlMDhhNGZmODBmMjU5NzI5ZDM5NDMyZjFmODU1ODJkODBkYzMwZDlmNTE0NWYzZDM4MWVkZDcxMDhmNTNjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bnRwvuG8xLv7zq7C9w7CMI8CtKgAK-0nQAB5XsYntLQ)
What do you think should we proceed as is or what ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ooooooooooooooooooooooooooooo i absolutely missed that, that's delicious - I can update!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's the right attitude ❤️ 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixeddddddddddddddddddd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wizard back to workkkk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well and LGTM!, lets kick the beta out 😎
🎯 @allgandalf, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #56774. |
Didn't get to reviewing this today, will review first thing tomorrow morning! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Explanation of Change
Removing beta now that everyone is on this beta as of 2 weeks ago & no issues have been found! (see linked issue)
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/431468
Tests
Offline tests
Same as above, all while offline
QA Steps
Same as above
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop